Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core/toast): add position top-right #432

Merged
merged 5 commits into from
Mar 15, 2023
Merged

feat(core/toast): add position top-right #432

merged 5 commits into from
Mar 15, 2023

Conversation

nuke-ellington
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@nuke-ellington nuke-ellington linked an issue Mar 8, 2023 that may be closed by this pull request
Need the placement attribute for changing the position of toast #267
Closed
@danielleroux danielleroux changed the title 267 need the placement attribute for changing the position of toast feat(core/toast): add position top-right Mar 9, 2023
@danielleroux danielleroux added the pull request affects minor version The pull request affects only minor version label Mar 9, 2023
@danielleroux danielleroux added this to the 1.5.0 milestone Mar 9, 2023
danielleroux
danielleroux requested changes Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

position should be part of the ToastConfig.

export interface ToastConfig {
  title?: string;
  message: string | HTMLElement;
  type?: ToastType;
  position: ToastPosition;  <--------
  autoClose?: boolean;
  autoCloseDelay?: number;
  icon?: string;
  iconColor?: string;
}

@danielleroux danielleroux merged commit ed88175 into main Mar 15, 2023
@danielleroux danielleroux deleted the 267-need-the-placement-attribute-for-changing-the-position-of-toast branch March 15, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleroux danielleroux danielleroux approved these changes

Assignees
No one assigned
Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Need the placement attribute for changing the position of toast
2 participants
@nuke-ellington @danielleroux